Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable size field and show helper text when editing an unbound storage #3451

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Disable size field and show helper text when editing an unbound storage #3451

merged 1 commit into from
Nov 7, 2024
+93 −45

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Nov 7, 2024 •
edited
Loading

JIRA: RHOAIENG-526

Description

When editing storage, if it's not "Bound", we disable the size field and show a helper text to explain why.

Screenshot 2024-11-07 at 1 26 03 PM

How Has This Been Tested?

  1. Create a new cluster storage, and don't connect it to any workbench
  2. Try to edit the storage, check whether the size field is disabled and the helper text is shown
  3. Try to connect it to a workbench, and start/restart that workbench
  4. Wait for a few second (it may take a few second to make the PVC on the cluster bound with a PV), and try to edit the cluster storage again
  5. Now you can see it's enabled and you can increase the size now

Test Impact

Added a cypress test to verify you cannot edit the storage size field when it's not bound.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (0e4420f) to head (40379b9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
- Coverage   85.64%   85.63%   -0.01%     
==========================================
  Files        1347     1347              
  Lines       30661    30668       +7     
  Branches     8531     8537       +6     
==========================================
+ Hits        26261    26264       +3     
- Misses       4400     4404       +4
Files with missing lines Coverage Δ
frontend/src/components/ValueUnitField.tsx 96.77% <100.00%> (+0.10%) ⬆️
...tend/src/pages/projects/components/PVSizeField.tsx 100.00% <100.00%> (ø)
...ojects/screens/detail/storage/BaseStorageModal.tsx 81.39% <100.00%> (ø)
...ects/screens/detail/storage/ManageStorageModal.tsx 0.00% <ø> (ø)
...creens/spawner/storage/CreateNewStorageSection.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4420f...40379b9. Read the comment docs.

Gkrumbach07
Gkrumbach07 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
/lgtm

works as expected

@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 91584ea into opendatahub-io:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gkrumbach07 Gkrumbach07 Gkrumbach07 approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@pnaik1 pnaik1 Awaiting requested review from pnaik1

Assignees

@Gkrumbach07 Gkrumbach07

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaoDaoNoCode @Gkrumbach07